Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unistore: Adjust some behaviors to be consistent with TiKV (#43397) #43471

Merged
merged 3 commits into from
May 26, 2023
Merged

unistore: Adjust some behaviors to be consistent with TiKV (#43397) #43471

merged 3 commits into from
May 26, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43397

What problem does this PR solve?

Issue Number: ref #42937
ref #43243

Problem Summary:

What is changed and how it works?

Follows some latest behavior changes to TiKV:

And fixes some existing incorrect behaviors:

  • ScanLock return complete lock info
  • Commit do not omit Lock records Removing this change from this PR due to too many problems in the current implementation of unistore.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 27, 2023
Merged
12 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 27, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • ekexium

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Apr 27, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 23, 2023
@MyonKeminta MyonKeminta reopened this May 23, 2023
ekexium
ekexium approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@ekexium ekexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts need to be resolved

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2023
@MyonKeminta
fix conflict; update kvproto
0ee1624 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
update bazel
fac2ee2 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Copy link
Contributor

/retest

1 similar comment
@MyonKeminta
Copy link
Contributor

/retest

@MyonKeminta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 24, 2023

@MyonKeminta: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 26, 2023
@crazycs520
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: fac2ee2

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2023
@MyonKeminta
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit fcd90c9 into pingcap:release-6.5 May 26, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekexium ekexium ekexium approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

Assignees

@MyonKeminta MyonKeminta

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @MyonKeminta @crazycs520 @ekexium @VelocityLight